mac: Fix bookmark drag and drop.

mac: Fix bookmark drag and drop.

The NSPasteboardItem that represents the dragged item needs to include all the
usual pasteboard types associated with URLs. This was broken in a recent
refactor that removed the use of a deprecated APIs.

BUG=600295
Committed: https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6
Cr-Commit-Position: refs/heads/master@{#385210}

[erikchen, 2016-04-04 18:45:58]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-04-04 18:45:58]

avi: Please review.

[erikchen, 2016-04-04 18:46:05]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 18:46:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854223002/1

[Avi (use Gerrit), 2016-04-04 18:55:27]

lgtm

https://codereview.chromium.org/1854223002/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm (right):

https://codereview.chromium.org/1854223002/diff/1/components/bookmarks/browse...
components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm:235:
forType:NSPasteboardTypeString];
ui::ClipboardUtil::UTIForPasteboardType? When is that used?

[erikchen, 2016-04-04 19:01:36]

https://codereview.chromium.org/1854223002/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm (right):

https://codereview.chromium.org/1854223002/diff/1/components/bookmarks/browse...
components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm:235:
forType:NSPasteboardTypeString];
On 2016/04/04 18:55:26, Avi wrote:
> ui::ClipboardUtil::UTIForPasteboardType? When is that used?

It's used for Pasteboard types not are not already UTIs. Basically, custom
pboard types and deprecated pboard types.

[commit-bot: I haz the power, 2016-04-04 19:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 19:02:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[erikchen, 2016-04-04 19:04:12]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-04 19:04:12]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1854223002/#ps20001
(title: "Compile error.")

[commit-bot: I haz the power, 2016-04-04 19:04:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854223002/20001

[commit-bot: I haz the power, 2016-04-04 20:59:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 20:59:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-04-04 22:03:38]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-04-04 22:03:38]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1854223002/#ps40001
(title: "Fix memory leak.")

[commit-bot: I haz the power, 2016-04-04 22:04:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854223002/40001

[commit-bot: I haz the power, 2016-04-05 00:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 00:06:03]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[erikchen, 2016-04-05 17:25:54]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:26:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854223002/40001

[commit-bot: I haz the power, 2016-04-05 17:32:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 17:33:59]

Description was changed from

==========
mac: Fix bookmark drag and drop.

The NSPasteboardItem that represents the dragged item needs to include all the
usual pasteboard types associated with URLs. This was broken in a recent
refactor that removed the use of a deprecated APIs.

BUG=600295
==========

to

==========
mac: Fix bookmark drag and drop.

The NSPasteboardItem that represents the dragged item needs to include all the
usual pasteboard types associated with URLs. This was broken in a recent
refactor that removed the use of a deprecated APIs.

BUG=600295

Committed: https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6
Cr-Commit-Position: refs/heads/master@{#385210}
==========

[commit-bot: I haz the power, 2016-04-05 17:34:03]

Patchset 3 (id:??) landed as
https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6
Cr-Commit-Position: refs/heads/master@{#385210}