chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm - Issue 1854223002: mac: Fix bookmark drag and drop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

Issue 1854223002: mac: Fix bookmark drag and drop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp37_dnd

Patch Set: Fix memory leak. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

index 51510e0dd7f3b31d61f08b5919aef8e49d3aea5a..349875136e0a8f677676516ce7c86525326b32e4 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

@@ -1333,10 +1333,11 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {

#pragma mark BookmarkButtonDelegate Protocol

-- (void)fillPasteboard:(NSPasteboard*)pboard

- forDragOfButton:(BookmarkButton*)button {

- [[self folderTarget] fillPasteboard:pboard forDragOfButton:button];

+- (NSPasteboardItem*)pasteboardItemForDragOfButton:(BookmarkButton*)button {

+ return [[self folderTarget] pasteboardItemForDragOfButton:button];

+- (void)willBeginPasteboardDrag {

// Close our folder menu and submenus since we know we're going to be dragged.

[self closeBookmarkFolder:self];

}