Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185413019: Used scoped_ptr in InitMessagePumpForUIFactory and CreateMessagePumpForType (Closed)

Created:
6 years, 9 months ago by suyash
Modified:
6 years, 9 months ago
CC:
chromium-reviews, sadrul, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Used scoped_ptr There was this TODO(sky): convert this and InitMessagePumpForUIFactory() to return a scoped_ptr. This patch is for doing the same. R=darin@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255643

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing the comments made #

Patch Set 3 : Adding myself to AUTHORS #

Patch Set 4 : Change done in accordance to build fail #

Patch Set 5 : Fixed build errors #

Patch Set 6 : Rebase #

Patch Set 7 : Changes done in accordance to build failure and Rebase #

Patch Set 8 : Changes in accordance to build fail for linux chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M AUTHORS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M base/message_loop/message_loop.h View 1 2 3 4 2 chunks +2 lines, -5 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 2 3 4 5 6 7 3 chunks +14 lines, -14 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/test/test_support_android.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_support_ios.mm View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_layout_tests_android.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/content_test_launcher.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/message_pump_mojo_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 38 (0 generated)
suyash
Please review.
6 years, 9 months ago (2014-03-04 13:49:04 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/185413019/diff/1/base/message_loop/message_loop.cc File base/message_loop/message_loop.cc (left): https://codereview.chromium.org/185413019/diff/1/base/message_loop/message_loop.cc#oldcode90 base/message_loop/message_loop.cc:90: nit: I think it was better to have ...
6 years, 9 months ago (2014-03-05 00:37:05 UTC) #2
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 04:44:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/20001
6 years, 9 months ago (2014-03-05 04:47:46 UTC) #4
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 04:48:41 UTC) #5
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 04:50:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/40001
6 years, 9 months ago (2014-03-05 04:53:46 UTC) #7
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 05:09:47 UTC) #8
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 05:27:10 UTC) #9
Nico
AUTHORS CHANGE LGTM< I CHECK THAT YOU"VE SIGNED THE CLA ABOUT THE CL DESCRIPTION: PLEASE ...
6 years, 9 months ago (2014-03-05 05:28:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/60001
6 years, 9 months ago (2014-03-05 05:29:05 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 06:19:55 UTC) #12
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=157254
6 years, 9 months ago (2014-03-05 06:19:55 UTC) #13
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 13:48:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/80001
6 years, 9 months ago (2014-03-05 13:48:19 UTC) #15
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 14:00:50 UTC) #16
suyash
On 2014/03/05 14:00:50, suyash.s wrote: > The CQ bit was unchecked by mailto:suyash.s@samsung.com @darin: I ...
6 years, 9 months ago (2014-03-05 14:09:15 UTC) #17
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 14:48:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/100001
6 years, 9 months ago (2014-03-05 14:49:59 UTC) #19
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 15:07:31 UTC) #20
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 15:25:59 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/120001
6 years, 9 months ago (2014-03-05 15:26:38 UTC) #22
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-05 16:06:59 UTC) #23
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-06 09:19:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/120001
6 years, 9 months ago (2014-03-06 09:19:34 UTC) #25
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-06 09:21:25 UTC) #26
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-06 13:11:02 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/130001
6 years, 9 months ago (2014-03-06 13:11:48 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 13:22:54 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 13:22:55 UTC) #30
suyash
The CQ bit was unchecked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-06 13:42:58 UTC) #31
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-07 05:08:34 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/130001
6 years, 9 months ago (2014-03-07 05:12:03 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 06:26:37 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 06:26:38 UTC) #35
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 9 months ago (2014-03-07 08:45:29 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/185413019/130001
6 years, 9 months ago (2014-03-07 08:46:58 UTC) #37
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 17:03:56 UTC) #38
Message was sent while issue was closed. 
Change committed as 255643

Powered by Google App Engine
This is Rietveld 408576698