base/test/test_support_android.cc - Issue 185413019: Used scoped_ptr in InitMessagePumpForUIFactory and CreateMessagePumpForType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/test_support_android.cc

Issue 185413019: Used scoped_ptr in InitMessagePumpForUIFactory and CreateMessagePumpForType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes in accordance to build fail for linux chromeos Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/test/test_support_android.cc

diff --git a/base/test/test_support_android.cc b/base/test/test_support_android.cc

index 1ad4c2b0db035c642c459cbbab4e90f5aa606369..b67ecacfb6cde8026f94835f529a2aabb88bc37e 100644

--- a/base/test/test_support_android.cc

+++ b/base/test/test_support_android.cc

@@ -133,8 +133,8 @@ class MessagePumpForUIStub : public base::MessagePumpForUI {

}

};

-base::MessagePump* CreateMessagePumpForUIStub() {

- return new MessagePumpForUIStub();

+scoped_ptr<base::MessagePump> CreateMessagePumpForUIStub() {

+ return scoped_ptr<base::MessagePump>(new MessagePumpForUIStub());

};

// Provides the test path for DIR_MODULE and DIR_ANDROID_APP_DATA.

« no previous file with comments | « base/message_loop/message_loop_unittest.cc ('k') | base/test/test_support_ios.mm » ('j') | no next file with comments »