Issue 185413015: Update the navbar in the observatory

Issue 185413015: Update the navbar in the observatory (Closed)

Created:
6 years, 9 months ago by turnidge

Modified:
6 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update the navbar in the observatory R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33292

Patch Set 3 : rebase to master #

Total comments: 2

Patch Set 4 : gen js / fix bugs #

Patch Set 6 : new js #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5582 lines, -3508 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3 4 5	20 chunks	+311 lines, -43 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View		526 chunks	+2229 lines, -1639 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html	View	1 2 3 4 5	20 chunks	+311 lines, -43 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View		526 chunks	+2229 lines, -1639 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/observatory_elements.dart	View	4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/observatory_elements.html	View	4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/isolate.dart	View	1 2 4 5	3 chunks	+17 lines, -13 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart	View	4 5	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/model.dart	View	1 2 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/breakpoint_list.dart	View	4 5	2 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/breakpoint_list.html	View	1 2 3 4 5	2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.dart	View	4 5	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/class_view.html	View	1 2 3 4 5	1 chunk	+11 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html	View	4 5	2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.dart	View	4 5	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/field_view.html	View	1 2 3 4 5	2 chunks	+17 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/function_view.dart	View	4 5	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/function_view.html	View	1 2 3 4 5	2 chunks	+17 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart	View	1 2 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.html	View	1 2 3 4 5	1 chunk	+9 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.dart	View	4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/instance_view.html	View	4 5	1 chunk	+12 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.dart	View	4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_list.html	View	1 2 3 4 5	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.dart	View	1 2 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_profile.html	View	1 2 3 4 5	1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/isolate_summary.html	View	4 5	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.dart	View	4 5	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html	View	1 2 3 4 5	1 chunk	+9 lines, -1 line	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/observatory_elements/nav_bar.dart	View	4 5	1 chunk	+84 lines, -0 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/observatory_elements/nav_bar.html	View	4 5	1 chunk	+193 lines, -0 lines	0 comments	Download
D	runtime/bin/vmservice/client/lib/src/observatory_elements/navigation_bar.dart	View	4 5	1 chunk	+0 lines, -13 lines	0 comments	Download
D	runtime/bin/vmservice/client/lib/src/observatory_elements/navigation_bar.html	View	4 5	1 chunk	+0 lines, -19 lines	0 comments	Download
D	runtime/bin/vmservice/client/lib/src/observatory_elements/navigation_bar_isolate.dart	View	4 5	1 chunk	+0 lines, -47 lines	0 comments	Download
D	runtime/bin/vmservice/client/lib/src/observatory_elements/navigation_bar_isolate.html	View	4 5	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_application.html	View	1 2 3 4 5	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/observatory_element.html	View	4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.html	View	4 5	2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart	View	1 2 4 5	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.html	View	1 2 3 4 5	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/185413015/diff/40001/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html File runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html (right): https://codereview.chromium.org/185413015/diff/40001/runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html#newcode13 runtime/bin/vmservice/client/lib/src/observatory_elements/code_view.html:13: <nav-menu link="." anchor="{{ code.functionRef['user_name'] }}" last="{{ true }}"></nav-menu> What ...

6 years, 9 months ago (2014-03-04 00:36:27 UTC) #2

turnidge

6 years, 9 months ago (2014-03-04 19:11:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 manually as r33292 (presubmit successful).

Expand Messages | Collapse Messages