Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart

Issue 185413015: Update the navbar in the observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: new js Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart
index 7bc0e2c717aca0520dbaa8840e3d7c6ca5e820cd..82569497caac1398ca4ee0e8e8c505f7c2d19b86 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.dart
@@ -5,9 +5,9 @@
library stack_trace_element;
import 'dart:html';
-import 'observatory_element.dart';
import 'package:logging/logging.dart';
import 'package:polymer/polymer.dart';
+import 'observatory_element.dart';
@CustomTag('stack-trace')
class StackTraceElement extends ObservatoryElement {
@@ -15,12 +15,12 @@ class StackTraceElement extends ObservatoryElement {
StackTraceElement.created() : super.created();
- void refresh(Event e, var detail, Node target) {
+ void refresh(var done) {
var url = app.locationManager.currentIsolateRelativeLink('stacktrace');
app.requestManager.requestMap(url).then((map) {
trace = map;
}).catchError((e, trace) {
Logger.root.severe('Error while reloading stack trace: $e\n$trace');
- });
+ }).whenComplete(done);
}
}

Powered by Google App Engine
This is Rietveld 408576698