Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 18541002: Introduce the WebState iOS provider interface. (Closed)

Created:
7 years, 5 months ago by blundell
Modified:
7 years, 5 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Visibility:
Public.

Description

Introduce the WebState iOS provider interface. This interface will serve a purpose similar to that of WebContents on content-based platforms. This CL also changes the structure of the gypfiles under ios/ to be divided by sub-module (e.g., base vs. chrome) rather than portion of the API layer (consumer vs. provider). The latter structure was flawed in that it would eventually have caused GYP to complain about circular dependencies: provider targets from higher-level modules will have to depend on consumer targets from lower-level modules, and consumer targets from higher-level modules will have to depend on provider targets from lower-level modules. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209956

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Fix #

Total comments: 14

Patch Set 4 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -84 lines) Patch
M ios/ios.gyp View 1 chunk +3 lines, -1 line 0 comments Download
A + ios/ios_base.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/ios_consumer.gyp View 1 chunk +0 lines, -41 lines 0 comments Download
A + ios/ios_tests_unit.gyp View 2 chunks +2 lines, -18 lines 0 comments Download
A + ios/ios_web.gyp View 1 2 3 1 chunk +10 lines, -9 lines 0 comments Download
A ios/public/provider/web/web_state.h View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A ios/public/provider/web/web_state_user_data.h View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
blundell
7 years, 5 months ago (2013-07-02 14:56:24 UTC) #1
blundell
Ready for review
7 years, 5 months ago (2013-07-02 15:04:37 UTC) #2
stuartmorgan
https://codereview.chromium.org/18541002/diff/5001/ios/ios_web.gyp File ios/ios_web.gyp (right): https://codereview.chromium.org/18541002/diff/5001/ios/ios_web.gyp#newcode12 ios/ios_web.gyp:12: 'variables': { 'enable_wexit_time_destructors': 1, }, Why here, but not ...
7 years, 5 months ago (2013-07-02 15:24:26 UTC) #3
blundell
https://codereview.chromium.org/18541002/diff/5001/ios/ios_web.gyp File ios/ios_web.gyp (right): https://codereview.chromium.org/18541002/diff/5001/ios/ios_web.gyp#newcode12 ios/ios_web.gyp:12: 'variables': { 'enable_wexit_time_destructors': 1, }, Gone. On 2013/07/02 15:24:26, ...
7 years, 5 months ago (2013-07-02 16:16:37 UTC) #4
stuartmorgan
lgtm
7 years, 5 months ago (2013-07-03 09:23:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/18541002/11001
7 years, 5 months ago (2013-07-03 09:24:59 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 11:42:34 UTC) #7
Message was sent while issue was closed.
Change committed as 209956

Powered by Google App Engine
This is Rietveld 408576698