ios/public/provider/web/web_state.h - Issue 18541002: Introduce the WebState iOS provider interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/public/provider/web/web_state.h

Issue 18541002: Introduce the WebState iOS provider interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	stuartmorgan 2013/07/02 15:24:26 s/(c) 2012/2013/ s/(c) 2012/2013/ blundell 2013/07/02 16:16:37 Done. Show quoted text On 2013/07/02 15:24:26, stuartmorgan wrote: > s/(c) 2012/2013/ Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_PUBLIC_PROVIDER_WEB_WEB_STATE_H_

	6 #define IOS_PUBLIC_PROVIDER_WEB_WEB_STATE_H_

	7

	8 #include "ios/public/consumer/base/supports_user_data.h"

	9

	10 namespace ios {

	11

	12 // Core interface for interaction with the web. There is one WebState per tab.
	stuartmorgan 2013/07/02 15:24:26 Since web/ is intended to parallel content/, we sh Since web/ is intended to parallel content/, we shouldn't mention the concept of tabs. See the comment for WebContents. blundell 2013/07/02 16:16:37 Removed. Didn't add anything else, since this inte Removed. Didn't add anything else, since this interface is empty at the current time. On 2013/07/02 15:24:26, stuartmorgan wrote: Show quoted text > Since web/ is intended to parallel content/, we shouldn't mention the concept of > tabs. See the comment for WebContents.
	13 class WebState : public ios::SupportsUserData {

	14 protected:

	15 WebState() {}

	16 virtual ~WebState() {}
	stuartmorgan 2013/07/02 15:24:26 These are intended one level too far. Also, why is These are intended one level too far. Also, why is the destructor protected? blundell 2013/07/02 16:16:37 Done. Show quoted text On 2013/07/02 15:24:26, stuartmorgan wrote: > These are intended one level too far. Also, why is the destructor protected? Done.
	17 };

	18

	19 } // namespace ios

	20

	21 #endif // IOS_PUBLIC_PROVIDER_WEB_WEB_STATE_H_

OLD	NEW

« ios/ios_web.gyp ('K') | « ios/ios_web.gyp ('k') | ios/public/provider/web/web_state_user_data.h » ('j') | ios/public/provider/web/web_state_user_data.h » ('J')