Issue 185403008: DevTools: allow selecting and showing details for coalesced record.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185403008: DevTools: allow selecting and showing details for coalesced record. (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
caseq, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: allow selecting and showing details for coalesced record. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168314

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comment addressed. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -6 lines)			Patch
	M	Source/devtools/front_end/TimelinePanel.js	View	1	3 chunks	+17 lines, -1 line	0 comments	Download
	M	Source/devtools/front_end/TimelineView.js	View		2 chunks	+26 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

caseq

lgtm https://codereview.chromium.org/185403008/diff/1/Source/devtools/front_end/TimelinePanel.js File Source/devtools/front_end/TimelinePanel.js (right): https://codereview.chromium.org/185403008/diff/1/Source/devtools/front_end/TimelinePanel.js#newcode852 Source/devtools/front_end/TimelinePanel.js:852: var fragment = document.createDocumentFragment(); This seems redundant.

6 years, 9 months ago (2014-03-03 15:31:17 UTC) #2

pfeldman

6 years, 9 months ago (2014-03-03 15:51:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r168314 (presubmit successful).

Expand Messages | Collapse Messages