Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 185403008: DevTools: allow selecting and showing details for coalesced record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comment addressed. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/TimelineView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelinePanel.js
diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js
index 449cdc2271b9a9fb05ff53aac0c057be7f04cc69..7c4e0170a3a6b823d524ccca6ad52ff44b78f79d 100644
--- a/Source/devtools/front_end/TimelinePanel.js
+++ b/Source/devtools/front_end/TimelinePanel.js
@@ -749,6 +749,7 @@ WebInspector.TimelinePanel.prototype = {
{
var startTime = this._windowStartTime;
var endTime = this._windowEndTime;
+
// Return early in case 0 selection window.
if (startTime < 0)
return;
@@ -841,6 +842,15 @@ WebInspector.TimelinePanel.prototype = {
}
},
+ /**
+ * @param {string} title
+ * @param {!Object} aggregatedStats
+ */
+ showAggregatedStatsInDetails: function(title, aggregatedStats)
+ {
+ this._detailsView.setContent(title, WebInspector.TimelineUIUtils.generatePieChart(aggregatedStats));
+ },
+
__proto__: WebInspector.Panel.prototype
}
@@ -945,7 +955,13 @@ WebInspector.TimelineModeViewDelegate.prototype = {
/**
* @param {?WebInspector.TimelineModel.Record} record
*/
- selectRecord: function(record) {}
+ selectRecord: function(record) {},
+
+ /**
+ * @param {string} title
+ * @param {!Object} aggregatedStats
+ */
+ showAggregatedStatsInDetails: function(title, aggregatedStats) {}
}
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/TimelineView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698