Revert "Add [WillBeGarbageCollected] to Event.idl"

Revert "Add [WillBeGarbageCollected] to Event.idl"

This CL caused a lot of failures in oilpan bots:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/1657

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168305

[haraken, 2014-03-03 07:55:44]

PTAL

I manually resolved several conflicts, but there was no non-trivial conflicts.

[tkent, 2014-03-03 08:06:52]

lgtm

https://codereview.chromium.org/185393006/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBVersionChangeEvent.cpp (left):

https://codereview.chromium.org/185393006/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBVersionChangeEvent.cpp:34: 
looks unnecessary change.

[sof, 2014-03-03 08:10:20]

Have you looked into why they're failing, i.e., is this a single bug or many?

[I did notice that a media test was allocating an Event (dispatching it) during
finalization, btw.]

[kouhei (in TOK), 2014-03-03 08:14:12]

> [I did notice that a media test was allocating an Event (dispatching it)
during
> finalization, btw.]
I have a fix for that locally. I'll upload the CL in a minute.

[haraken, 2014-03-03 08:28:07]

On 2014/03/03 08:10:20, sof wrote:
> Have you looked into why they're failing, i.e., is this a single bug or many?
> 
> [I did notice that a media test was allocating an Event (dispatching it)
during
> finalization, btw.]

Unfortunately, many. Two big failures are:

- Event is created during destructors in a couple of call paths.
- ASSERT(m_workerGlobalScope->hasOneRef()) is triggered in a lot of tests, since
(for some reason) moving Event to the heap changes the lifetime of
WorkerglobalScope's wrapper that has the second reference to the
WorkerGlobalScope.

So we decided that it would be better to revert the CLs, stabilize the tree, and
then investigate the issue.

[haraken, 2014-03-03 08:29:08]

https://codereview.chromium.org/185393006/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBVersionChangeEvent.cpp (left):

https://codereview.chromium.org/185393006/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBVersionChangeEvent.cpp:34: 
On 2014/03/03 08:06:53, tkent wrote:
> looks unnecessary change.

Done.

[haraken, 2014-03-03 08:29:35]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-03 08:29:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/185393006/20001

[Mads Ager (chromium), 2014-03-03 08:33:16]

LGTM, thanks Haraken. Let's hope we can get this in again soon with fixes for
the failures. :-)

[wibling-chromium, 2014-03-03 08:52:10]

lgtm

https://codereview.chromium.org/185393006/diff/20001/Source/core/events/Mouse...
File Source/core/events/MouseEvent.h (right):

https://codereview.chromium.org/185393006/diff/20001/Source/core/events/Mouse...
Source/core/events/MouseEvent.h:105: virtual void trace(Visitor*) OVERRIDE;
Do we need this trace method on MouseEvent now that is it not on the oilpan
heap?

[haraken, 2014-03-03 08:55:54]

https://codereview.chromium.org/185393006/diff/20001/Source/core/events/Mouse...
File Source/core/events/MouseEvent.h (right):

https://codereview.chromium.org/185393006/diff/20001/Source/core/events/Mouse...
Source/core/events/MouseEvent.h:105: virtual void trace(Visitor*) OVERRIDE;
On 2014/03/03 08:52:11, wibling-chromium wrote:
> Do we need this trace method on MouseEvent now that is it not on the oilpan
> heap?

Event is still RefCountedGarbageCollected after landing this CL. I'll revert it
in a next CL.

[wibling-chromium, 2014-03-03 09:29:46]

On 2014/03/03 08:55:54, haraken wrote:
>
https://codereview.chromium.org/185393006/diff/20001/Source/core/events/Mouse...
> File Source/core/events/MouseEvent.h (right):
> 
>
https://codereview.chromium.org/185393006/diff/20001/Source/core/events/Mouse...
> Source/core/events/MouseEvent.h:105: virtual void trace(Visitor*) OVERRIDE;
> On 2014/03/03 08:52:11, wibling-chromium wrote:
> > Do we need this trace method on MouseEvent now that is it not on the oilpan
> > heap?
> 
> Event is still RefCountedGarbageCollected after landing this CL. I'll revert
it
> in a next CL.

Missed that. Thanks for the explanation.

[commit-bot: I haz the power, 2014-03-03 11:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 11:30:36]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[haraken, 2014-03-03 11:36:56]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-03 11:37:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/185393006/20001

[commit-bot: I haz the power, 2014-03-03 12:52:02]

Change committed as 168305