Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: Source/core/events/MouseEvent.h

Issue 185393006: Revert "Add [WillBeGarbageCollected] to Event.idl" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/MessageEvent.cpp ('k') | Source/core/events/MouseEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/MouseEvent.h
diff --git a/Source/core/events/MouseEvent.h b/Source/core/events/MouseEvent.h
index a362f43a04827fe0b4d5f2a6966bed3e508495c2..77ba12b5925633c13c7db131ecd8ba19c43bcbe6 100644
--- a/Source/core/events/MouseEvent.h
+++ b/Source/core/events/MouseEvent.h
@@ -50,20 +50,20 @@ struct MouseEventInit : public UIEventInit {
class MouseEvent : public MouseRelatedEvent {
public:
- static PassRefPtrWillBeRawPtr<MouseEvent> create()
+ static PassRefPtr<MouseEvent> create()
{
- return adoptRefWillBeRefCountedGarbageCollected(new MouseEvent);
+ return adoptRef(new MouseEvent);
}
- static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<AbstractView>,
+ static PassRefPtr<MouseEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<AbstractView>,
int detail, int screenX, int screenY, int pageX, int pageY,
int movementX, int movementY,
bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button,
PassRefPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<Clipboard>, bool isSimulated = false);
- static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& eventType, PassRefPtr<AbstractView>, const PlatformMouseEvent&, int detail, PassRefPtr<Node> relatedTarget);
+ static PassRefPtr<MouseEvent> create(const AtomicString& eventType, PassRefPtr<AbstractView>, const PlatformMouseEvent&, int detail, PassRefPtr<Node> relatedTarget);
- static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& eventType, const MouseEventInit&);
+ static PassRefPtr<MouseEvent> create(const AtomicString& eventType, const MouseEventInit&);
virtual ~MouseEvent();
@@ -91,8 +91,6 @@ public:
virtual bool isDragEvent() const OVERRIDE FINAL;
virtual int which() const OVERRIDE FINAL;
- virtual void trace(Visitor*) OVERRIDE;
-
protected:
MouseEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<AbstractView>,
int detail, int screenX, int screenY, int pageX, int pageY,
@@ -104,6 +102,8 @@ protected:
MouseEvent();
+ virtual void trace(Visitor*) OVERRIDE;
wibling-chromium 2014/03/03 08:52:11 Do we need this trace method on MouseEvent now tha
haraken 2014/03/03 08:55:55 Event is still RefCountedGarbageCollected after la
+
private:
unsigned short m_button;
bool m_buttonDown;
@@ -113,7 +113,7 @@ private:
class SimulatedMouseEvent FINAL : public MouseEvent {
public:
- static PassRefPtrWillBeRawPtr<SimulatedMouseEvent> create(const AtomicString& eventType, PassRefPtr<AbstractView>, PassRefPtr<Event> underlyingEvent);
+ static PassRefPtr<SimulatedMouseEvent> create(const AtomicString& eventType, PassRefPtr<AbstractView>, PassRefPtr<Event> underlyingEvent);
virtual ~SimulatedMouseEvent();
virtual void trace(Visitor*) OVERRIDE;
« no previous file with comments | « Source/core/events/MessageEvent.cpp ('k') | Source/core/events/MouseEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698