Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1853793003: Remove content/renderer/npapi (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content/renderer/npapi BUG=493212 Committed: https://crrev.com/63d83f986fc2d5350032a6cfd47762f587b67ef7 Cr-Commit-Position: refs/heads/master@{#384994}

Patch Set 1 #

Patch Set 2 : fix win build #

Patch Set 3 : extra mac leftover #

Total comments: 3

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2514 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/npapi/plugin_channel_host.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/renderer/npapi/plugin_channel_host.cc View 1 chunk +0 lines, -156 lines 0 comments Download
D content/renderer/npapi/webplugin_delegate_proxy.h View 1 chunk +0 lines, -243 lines 0 comments Download
D content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -768 lines 0 comments Download
D content/renderer/npapi/webplugin_impl.h View 1 chunk +0 lines, -222 lines 0 comments Download
D content/renderer/npapi/webplugin_impl.cc View 1 chunk +0 lines, -638 lines 0 comments Download
D content/renderer/npapi/webplugin_impl_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 3 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 3 chunks +0 lines, -30 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 4 chunks +0 lines, -22 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 8 chunks +0 lines, -114 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (10 generated)
piman
4 years, 8 months ago (2016-04-01 23:36:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793003/1
4 years, 8 months ago (2016-04-01 23:54:48 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/191267)
4 years, 8 months ago (2016-04-02 00:21:24 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793003/20001
4 years, 8 months ago (2016-04-02 00:41:53 UTC) #8
piman
extra mac leftover
4 years, 8 months ago (2016-04-02 01:02:58 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793003/40001
4 years, 8 months ago (2016-04-02 01:04:04 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-02 02:13:32 UTC) #13
jam
https://codereview.chromium.org/1853793003/diff/40001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (left): https://codereview.chromium.org/1853793003/diff/40001/content/renderer/render_view_impl.cc#oldcode1215 content/renderer/render_view_impl.cc:1215: Send(new ViewHostMsg_PluginFocusChanged(GetRoutingID(), focused, plugin_id)); the browser side code should ...
4 years, 8 months ago (2016-04-04 17:27:31 UTC) #14
piman
https://codereview.chromium.org/1853793003/diff/40001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (left): https://codereview.chromium.org/1853793003/diff/40001/content/renderer/render_view_impl.cc#oldcode1397 content/renderer/render_view_impl.cc:1397: IPC_MESSAGE_HANDLER(ViewMsg_WindowFrameChanged, OnWindowFrameChanged) On 2016/04/04 17:27:31, jam wrote: > ditto ...
4 years, 8 months ago (2016-04-04 17:49:15 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793003/50001
4 years, 8 months ago (2016-04-04 19:21:33 UTC) #17
jam
On 2016/04/04 17:49:15, piman wrote: > https://codereview.chromium.org/1853793003/diff/40001/content/renderer/render_view_impl.cc > File content/renderer/render_view_impl.cc (left): > > https://codereview.chromium.org/1853793003/diff/40001/content/renderer/render_view_impl.cc#oldcode1397 > ...
4 years, 8 months ago (2016-04-04 19:36:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853793003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853793003/50001
4 years, 8 months ago (2016-04-04 19:55:41 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 8 months ago (2016-04-04 20:40:06 UTC) #22
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/63d83f986fc2d5350032a6cfd47762f587b67ef7 Cr-Commit-Position: refs/heads/master@{#384994}
4 years, 8 months ago (2016-04-04 20:41:38 UTC) #24
Will Harris
4 years, 8 months ago (2016-04-04 20:52:55 UTC) #25
Message was sent while issue was closed.
🎆

Powered by Google App Engine
This is Rietveld 408576698