Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1853653004: Windows: Convert mime types to lowercase in GetPlatformMimeTypeFromExtension. (Closed)

Created:
4 years, 8 months ago by themblsha
Modified:
4 years, 7 months ago
Reviewers:
Ryan Sleevi, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Windows: Convert mime types to lowercase in GetPlatformMimeTypeFromExtension. PluginList::GetPluginInfoArray() expects all incoming mime types to be lowercase, but this is not always the case when reading them from the Windows registry. One such offender is a .potm file extension: "Content Type"="application/vnd.ms-powerpoint.template.macroEnabled.12" BUG=

Patch Set 1 #

Patch Set 2 : Forgot to add required include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/base/platform_mime_util_win.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
themblsha
4 years, 8 months ago (2016-04-01 12:06:34 UTC) #3
Ryan Sleevi
Could you explain more why this isn't done at the PluginList ingesting, rather than here ...
4 years, 8 months ago (2016-04-01 16:58:16 UTC) #4
themblsha
On 2016/04/01 16:58:16, Ryan Sleevi wrote: > Could you explain more why this isn't done ...
4 years, 8 months ago (2016-04-07 12:20:44 UTC) #5
Ryan Sleevi
On 2016/04/07 12:20:44, themblsha wrote: > I thought that a DCHECK in PluginList::GetPluginInfoArray() means that ...
4 years, 8 months ago (2016-04-08 00:41:52 UTC) #6
themblsha
Thanks, created https://bugs.chromium.org/p/chromium/issues/detail?id=601776 with relevant stacktraces.
4 years, 8 months ago (2016-04-08 14:27:30 UTC) #7
Ryan Sleevi
I'm going to close this issue, based on the discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=601776 Would you like ...
4 years, 7 months ago (2016-04-27 20:43:50 UTC) #8
themblsha
4 years, 7 months ago (2016-04-29 10:15:24 UTC) #9
Message was sent while issue was closed.
On 2016/04/27 20:43:50, Ryan Sleevi wrote:
> I'm going to close this issue, based on the discussion in
> https://bugs.chromium.org/p/chromium/issues/detail?id=601776
> 
> Would you like to continue working on that solution? Otherwise, I can always
> mark it Available and see about getting a fix in eventually.

I won't have the time for this for the next two-three weeks. I'll try going back
to this later if it's still not resolved by then.

Powered by Google App Engine
This is Rietveld 408576698