Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: net/base/platform_mime_util_win.cc

Issue 1853653004: Windows: Convert mime types to lowercase in GetPlatformMimeTypeFromExtension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot to add required include. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/platform_mime_util.h" 5 #include "net/base/platform_mime_util.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
10 #include "base/win/registry.h" 11 #include "base/win/registry.h"
11 12
12 namespace net { 13 namespace net {
13 14
14 bool PlatformMimeUtil::GetPlatformMimeTypeFromExtension( 15 bool PlatformMimeUtil::GetPlatformMimeTypeFromExtension(
15 const base::FilePath::StringType& ext, std::string* result) const { 16 const base::FilePath::StringType& ext, std::string* result) const {
16 // check windows registry for file extension's mime type (registry key 17 // check windows registry for file extension's mime type (registry key
17 // names are not case-sensitive). 18 // names are not case-sensitive).
18 std::wstring value, key = L"." + ext; 19 std::wstring value, key = L"." + ext;
19 base::win::RegKey(HKEY_CLASSES_ROOT, key.c_str(), KEY_READ).ReadValue( 20 base::win::RegKey(HKEY_CLASSES_ROOT, key.c_str(), KEY_READ).ReadValue(
20 L"Content Type", &value); 21 L"Content Type", &value);
21 if (!value.empty()) { 22 if (!value.empty()) {
22 *result = base::WideToUTF8(value); 23 *result = base::ToLowerASCII(base::WideToUTF8(value));
23 return true; 24 return true;
24 } 25 }
25 return false; 26 return false;
26 } 27 }
27 28
28 bool PlatformMimeUtil::GetPreferredExtensionForMimeType( 29 bool PlatformMimeUtil::GetPreferredExtensionForMimeType(
29 const std::string& mime_type, base::FilePath::StringType* ext) const { 30 const std::string& mime_type, base::FilePath::StringType* ext) const {
30 std::wstring key( 31 std::wstring key(
31 L"MIME\\Database\\Content Type\\" + base::UTF8ToWide(mime_type)); 32 L"MIME\\Database\\Content Type\\" + base::UTF8ToWide(mime_type));
32 if (base::win::RegKey(HKEY_CLASSES_ROOT, key.c_str(), KEY_READ).ReadValue( 33 if (base::win::RegKey(HKEY_CLASSES_ROOT, key.c_str(), KEY_READ).ReadValue(
(...skipping 13 matching lines...) Expand all
46 // Multiple extensions could have the given mime type specified as their types 47 // Multiple extensions could have the given mime type specified as their types
47 // in their 'HKCR\.<extension>\Content Type' keys. Iterating all the HKCR 48 // in their 'HKCR\.<extension>\Content Type' keys. Iterating all the HKCR
48 // entries, though, is wildly impractical. Cheat by returning just the 49 // entries, though, is wildly impractical. Cheat by returning just the
49 // preferred extension. 50 // preferred extension.
50 base::FilePath::StringType ext; 51 base::FilePath::StringType ext;
51 if (GetPreferredExtensionForMimeType(mime_type, &ext)) 52 if (GetPreferredExtensionForMimeType(mime_type, &ext))
52 extensions->insert(ext); 53 extensions->insert(ext);
53 } 54 }
54 55
55 } // namespace net 56 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698