Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1853573002: [Extensions] Remove 'use_movable_types' from code generation (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove 'use_movable_types' from code generation The 'use_movable_types' compiler option was added to piecemeal migrate extension apis to use movable types in code generation. This completes the migration, so we can remove this support. The entry in the json/idl files will be removed separately. BUG=595949 Committed: https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6 Cr-Commit-Position: refs/heads/master@{#384649}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -84 lines) Patch
M chrome/browser/extensions/api/history/history_api.cc View 6 chunks +22 lines, -35 lines 1 comment Download
M tools/json_schema_compiler/cc_generator.py View 2 chunks +10 lines, -16 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 1 chunk +6 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator_test.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/h_generator.py View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/test/arrays_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M tools/json_schema_compiler/test/choices_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/idl_schemas_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
cleanup! https://codereview.chromium.org/1853573002/diff/20001/chrome/browser/extensions/api/history/history_api.cc File chrome/browser/extensions/api/history/history_api.cc (right): https://codereview.chromium.org/1853573002/diff/20001/chrome/browser/extensions/api/history/history_api.cc#newcode1 chrome/browser/extensions/api/history/history_api.cc:1: // Copyright (c) 2012 The Chromium Authors. All ...
4 years, 8 months ago (2016-04-01 01:38:24 UTC) #3
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-04-01 16:29:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853573002/20001
4 years, 8 months ago (2016-04-01 18:51:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-01 18:58:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:59:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da55d726a92435889ff6561fc3008765890d1f6
Cr-Commit-Position: refs/heads/master@{#384649}

Powered by Google App Engine
This is Rietveld 408576698