tools/json_schema_compiler/cpp_type_generator_test.py - Issue 1853573002: [Extensions] Remove 'use_movable_types' from code generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cpp_type_generator_test.py

Issue 1853573002: [Extensions] Remove 'use_movable_types' from code generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/history/history_api.cc ('K') | « tools/json_schema_compiler/cpp_type_generator.py ('k') | tools/json_schema_compiler/h_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/json_schema_compiler/cpp_type_generator_test.py

diff --git a/tools/json_schema_compiler/cpp_type_generator_test.py b/tools/json_schema_compiler/cpp_type_generator_test.py

index 69d80dcbc4cb719ca2e46fbf80905ef648eb39ab..db4e8cff1d10aaffe0908a521a9d5dc733ea7749 100755

--- a/tools/json_schema_compiler/cpp_type_generator_test.py

+++ b/tools/json_schema_compiler/cpp_type_generator_test.py

@@ -148,7 +148,7 @@ class CppTypeGeneratorTest(unittest.TestCase):

manager = CppTypeGenerator(self.models.get('windows'),

_FakeSchemaLoader(None))

self.assertEquals(

- 'std::vector<linked_ptr<Window> >',

+ 'std::vector<Window>',

manager.GetCppType(

self.windows.functions['getAll'].callback.params[0].type_))

manager = CppTypeGenerator(self.models.get('permissions'),

@@ -182,7 +182,7 @@ class CppTypeGeneratorTest(unittest.TestCase):

environment=CppNamespaceEnvironment('%(namespace)s'))

manager = CppTypeGenerator(m, _FakeSchemaLoader(m))

self.assertEquals(

- 'std::vector<linked_ptr<tabs::Tab> >',

+ 'std::vector<tabs::Tab>',

manager.GetCppType(

self.windows.types['Window'].properties['tabs'].type_))

@@ -193,7 +193,7 @@ class CppTypeGeneratorTest(unittest.TestCase):

manager.GetCppType(

self.permissions.types['Permissions'].properties['origins'].type_,

is_in_container=False))

- self.assertEquals('linked_ptr<std::vector<std::string> >',

+ self.assertEquals('std::vector<std::string>',

manager.GetCppType(

self.permissions.types['Permissions'].properties['origins'].type_,

is_in_container=True))