Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Unified Diff: third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp

Issue 1853543002: Add -ifsameorigin to autoplay experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autoplay
Patch Set: irebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp
diff --git a/third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp b/third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp
index e581a9405d10e149a543c3655aeca4698566831e..59118c27d729f83d18e18f60d682ab4b86af7f75 100644
--- a/third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp
+++ b/third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp
@@ -52,6 +52,8 @@ public:
.WillByDefault(Return(false));
ON_CALL(*this, pageVisibilityState())
.WillByDefault(Return(PageVisibilityStateVisible));
+ ON_CALL(*this, frame())
+ .WillByDefault(Return(nullptr));
ON_CALL(*this, absoluteBoundingBoxRect())
.WillByDefault(Return(
IntRect(10, 10, 100, 100)));
@@ -85,6 +87,7 @@ public:
MOCK_METHOD0(isLegacyViewportType, bool());
MOCK_CONST_METHOD0(pageVisibilityState, PageVisibilityState());
MOCK_CONST_METHOD0(autoplayExperimentMode, String());
+ MOCK_CONST_METHOD0(frame, LocalFrame*());
mlamouri (slow - plz ping) 2016/04/26 14:41:40 I wish we had more tests for this. Are there layou
liberato (no reviews please) 2016/04/26 18:30:24 yes, there are layout tests for this also: https:
MOCK_METHOD1(setRequestPositionUpdates, void(bool));
MOCK_CONST_METHOD0(absoluteBoundingBoxRect, IntRect());

Powered by Google App Engine
This is Rietveld 408576698