Add -ifsameorigin to autoplay experiment.

third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/Document.h"
 #include "core/html/AutoplayExperimentHelper.h"
 #include "platform/UserGestureIndicator.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 34 matching lines @@
 
         // Default to "not optimized for mobile" page.
         ON_CALL(*this, isLegacyViewportType())
             .WillByDefault(Return(false));
 
         // Other handy defaults.
         ON_CALL(*this, ended())
             .WillByDefault(Return(false));
         ON_CALL(*this, pageVisibilityState())
             .WillByDefault(Return(PageVisibilityStateVisible));
+        ON_CALL(*this, frame())
+            .WillByDefault(Return(nullptr));
         ON_CALL(*this, absoluteBoundingBoxRect())
             .WillByDefault(Return(
                 IntRect(10, 10, 100, 100)));
 
         // Normally, the autoplay experiment should not modify lots of other
         // state unless we explicitly expect it.
         EXPECT_CALL(*this, setMuted(_))
             .Times(0);
         EXPECT_CALL(*this, removeUserGestureRequirement())
             .Times(0);
@@ skipping 13 matching lines @@
     MOCK_METHOD0(playInternal, void());
     MOCK_CONST_METHOD0(isUserGestureRequiredForPlay, bool());
     MOCK_METHOD0(removeUserGestureRequirement, void());
     MOCK_METHOD1(recordAutoplayMetric, void(AutoplayMetrics));
     MOCK_METHOD0(shouldAutoplay, bool());
     MOCK_CONST_METHOD0(isHTMLVideoElement, bool());
     MOCK_CONST_METHOD0(isHTMLAudioElement, bool());
     MOCK_METHOD0(isLegacyViewportType, bool());
     MOCK_CONST_METHOD0(pageVisibilityState, PageVisibilityState());
     MOCK_CONST_METHOD0(autoplayExperimentMode, String());
+    MOCK_CONST_METHOD0(frame, LocalFrame*());

[mlamouri (slow - plz ping), 2016/04/26 14:41:40]

I wish we had more tests for this. Are there layout tests for the experiments?

[liberato (no reviews please), 2016/04/26 18:30:24]

yes, there are layout tests for this also:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

     MOCK_METHOD1(setRequestPositionUpdates, void(bool));
     MOCK_CONST_METHOD0(absoluteBoundingBoxRect, IntRect());
 
     const char* m_mode;
     // const since changes to it won't affect the mocked value.
     const double m_duration;
 };
 
 class AutoplayExperimentTest : public ::testing::Test {
 public:
@@ skipping 329 matching lines @@
 
     EXPECT_CALL(*m_client, removeUserGestureRequirement())
         .Times(1);
     EXPECT_CALL(*m_client, playInternal())
         .Times(1);
     EXPECT_CALL(*m_client, setRequestPositionUpdates(false))
         .Times(1);
     moveIntoViewport();
 }
 }