Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1853463002: 🍯 Reland of GN: Allow android lint to fail builds

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of GN: Allow android lint to fail builds This was enabled for GYP in June, but got missed for GN Reland ensures that --can-fail-build causes lint to re-run. BUG=607761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M build/android/gyp/lint.py View 2 chunks +4 lines, -4 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
agrieve
On 2016/03/31 19:31:07, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org Checked that the ...
4 years, 8 months ago (2016-03-31 19:31:47 UTC) #3
Yaron
4 years, 8 months ago (2016-03-31 20:24:32 UTC) #4 
On 2016/03/31 19:31:47, agrieve wrote:
> On 2016/03/31 19:31:07, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:yfriedman@chromium.org
> 
> Checked that the trybots fail this time. There are separate patches for all
the
> warnings, so just want this at the ready for when they land.

lgtm

Powered by Google App Engine
This is Rietveld 408576698