Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: build/android/gyp/lint.py

Issue 1853463002: 🍯 Reland of GN: Allow android lint to fail builds Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/lint.py
diff --git a/build/android/gyp/lint.py b/build/android/gyp/lint.py
index 71c1a6fa09c9f0624900c4a2771d97db2b3f4f28..4660f6fd41fcc8bf62bd469156a5538acf44371c 100755
--- a/build/android/gyp/lint.py
+++ b/build/android/gyp/lint.py
@@ -219,9 +219,6 @@ def main():
'directory tree should be stored.')
parser.add_argument('--platform-xml-path', required=True,
help='Path to api-platforms.xml')
- parser.add_argument('--create-cache', action='store_true',
- help='Mark the lint cache file as an output rather than '
- 'an input.')
parser.add_argument('--can-fail-build', action='store_true',
help='If set, script will exit with nonzero exit status'
' if lint errors are present')
@@ -276,7 +273,10 @@ def main():
if sources:
input_paths.extend(sources)
- input_strings = []
+ input_strings = [
+ args.can_fail_build,
+ args.silent,
+ ]
if args.processed_config_path:
input_strings.append(args.processed_config_path)
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698