Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2930)

Unified Diff: chrome/browser/ui/webui/settings/reset_settings_handler.h

Issue 1853413002: MD Settings: Convert reset_page/ to use browser proxy pattern. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix ChromeOS tests. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/reset_settings_handler.h
diff --git a/chrome/browser/ui/webui/settings/reset_settings_handler.h b/chrome/browser/ui/webui/settings/reset_settings_handler.h
index 4ee30cc8d3f0a18aaad72c1c0fecf2e87061f98a..f71cd3de043937d189c25e0c2952c9bd679e8a8b 100644
--- a/chrome/browser/ui/webui/settings/reset_settings_handler.h
+++ b/chrome/browser/ui/webui/settings/reset_settings_handler.h
@@ -50,27 +50,28 @@ class ResetSettingsHandler : public SettingsPageUIHandler {
virtual ProfileResetter* GetResetter();
// Javascript callback to start clearing data.
- void HandleResetProfileSettings(const base::ListValue* value);
+ void HandleResetProfileSettings(const base::ListValue* args);
private:
// Closes the dialog once all requested settings has been reset.
- void OnResetProfileSettingsDone(bool send_feedback);
+ void OnResetProfileSettingsDone(std::string callback_id,
tommycli 2016/04/05 18:46:28 optional nit: The placement of this method (spatia
dpapad 2016/04/05 19:23:12 Yes, done.
+ bool send_feedback);
// Called when the reset profile dialog is shown.
- void OnShowResetProfileDialog(const base::ListValue* value);
+ void OnShowResetProfileDialog(const base::ListValue* args);
// Called when the reset profile dialog is hidden.
- void OnHideResetProfileDialog(const base::ListValue* value);
+ void OnHideResetProfileDialog(const base::ListValue* args);
// Called when the reset profile banner is shown.
- void OnHideResetProfileBanner(const base::ListValue* value);
+ void OnHideResetProfileBanner(const base::ListValue* args);
// Called when BrandcodeConfigFetcher completed fetching settings.
void OnSettingsFetched();
// Resets profile settings to default values. |send_settings| is true if user
// gave his consent to upload broken settings to Google for analysis.
- void ResetProfile(bool send_settings);
+ void ResetProfile(std::string callback_id, bool send_settings);
// Sets new values for the feedback area.
void UpdateFeedbackUI();

Powered by Google App Engine
This is Rietveld 408576698