MD Settings: Convert reset_page/ to use browser proxy pattern.

chrome/browser/ui/webui/settings/reset_settings_handler.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 32 matching lines @@
   // WebUIMessageHandler implementation.
   void RegisterMessages() override;
 
  protected:
   ResetSettingsHandler(Profile* profile, bool allow_powerwash);
 
   // Overriden in tests to substitute with a test version of ProfileResetter.
   virtual ProfileResetter* GetResetter();
 
   // Javascript callback to start clearing data.
-  void HandleResetProfileSettings(const base::ListValue* value);
+  void HandleResetProfileSettings(const base::ListValue* args);
 
  private:
   // Closes the dialog once all requested settings has been reset.
-  void OnResetProfileSettingsDone(bool send_feedback);
+  void OnResetProfileSettingsDone(std::string callback_id,

[tommycli, 2016/04/05 18:46:28]

optional nit: The placement of this method (spatially) makes me think this is a
WebUI message handler, but really it should probably be directly below the
ResetProfile method. (It's only used there right?)

[dpapad, 2016/04/05 19:23:12]

Yes, done.

+                                  bool send_feedback);
 
   // Called when the reset profile dialog is shown.
-  void OnShowResetProfileDialog(const base::ListValue* value);
+  void OnShowResetProfileDialog(const base::ListValue* args);
 
   // Called when the reset profile dialog is hidden.
-  void OnHideResetProfileDialog(const base::ListValue* value);
+  void OnHideResetProfileDialog(const base::ListValue* args);
 
   // Called when the reset profile banner is shown.
-  void OnHideResetProfileBanner(const base::ListValue* value);
+  void OnHideResetProfileBanner(const base::ListValue* args);
 
   // Called when BrandcodeConfigFetcher completed fetching settings.
   void OnSettingsFetched();
 
   // Resets profile settings to default values. |send_settings| is true if user
   // gave his consent to upload broken settings to Google for analysis.
-  void ResetProfile(bool send_settings);
+  void ResetProfile(std::string callback_id, bool send_settings);
 
   // Sets new values for the feedback area.
   void UpdateFeedbackUI();
 
 #if defined(OS_CHROMEOS)
   // Will be called when powerwash dialog is shown.
   void OnShowPowerwashDialog(const base::ListValue* args);
 
   // Sets a pref indicating that a factory reset is requested and then requests
   // a restart.
@@ skipping 16 matching lines @@
   std::string brandcode_;
 
   base::WeakPtrFactory<ResetSettingsHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ResetSettingsHandler);
 };
 
 }  // namespace settings
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_