Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1853383002: Revert of Delete SkFlattenable::Type (Closed)

Created:
4 years, 8 months ago by mtklein
Modified:
4 years, 8 months ago
Reviewers:
msarett, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Delete SkFlattenable::Type (patchset #2 id:20001 of https://codereview.chromium.org/1834303003/ ) Reason for revert: Used by Chrome. c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C2039: 'GetFlattenableType': is not a member of 'SkColorFilter' c:\b\build\slave\workdir\build\src\third_party\skia\include\core\skshader.h(19): note: see declaration of 'SkColorFilter' c:\b\build\slave\workdir\build\src\cc\playback\compositing_display_item.cc(53): error C3861: 'GetFlattenableType': identifier not found Original issue's description: > Delete SkFlattenable::Type > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834303003 > > Committed: https://skia.googlesource.com/skia/+/99d9231f6a4cb6b85b8637e9d8ae32f8bd7c466f TBR=reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3b37545bc594a96de45eba62dea0ce478750f2a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -24 lines) Patch
M gm/imagefiltersbase.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkDrawLooper.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkFlattenable.h View 4 chunks +25 lines, -2 lines 0 comments Download
M include/core/SkFlattenableSerialization.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkMaskFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPathEffect.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkRasterizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkFlattenable.cpp View 2 chunks +19 lines, -1 line 0 comments Download
M src/core/SkFlattenableSerialization.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M src/utils/SkBitmapSourceDeserializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_fuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of Delete SkFlattenable::Type
4 years, 8 months ago (2016-04-04 21:57:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853383002/1
4 years, 8 months ago (2016-04-04 21:57:09 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:57:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3b37545bc594a96de45eba62dea0ce478750f2a9

Powered by Google App Engine
This is Rietveld 408576698