Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1853333005: Add layout tests to check Accept request header values observed by Service Worker

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 8 months ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout tests to check Accept request header values observed by Service Worker BUG=

Patch Set 1 #

Total comments: 3

Messages

Total messages: 4 (1 generated)
hiroshige
Accept header values in the spec (https://fetch.spec.whatwg.org/#fetching) are recommended values (indicated by the word 'should' ...
4 years, 8 months ago (2016-04-11 06:03:52 UTC) #2
nhiroki
https://codereview.chromium.org/1853333005/diff/1/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html (right): https://codereview.chromium.org/1853333005/diff/1/third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html#newcode125 third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-event.html:125: frame.remove(); Thanks to (*), an iframe created by with_iframe() ...
4 years, 8 months ago (2016-04-11 08:33:29 UTC) #3
nhiroki
4 years, 8 months ago (2016-04-11 08:37:42 UTC) #4
On 2016/04/11 06:03:52, hiroshige wrote:
> Accept header values in the spec (https://fetch.spec.whatwg.org/#fetching) are
> recommended values (indicated by the word 'should' e.g. in 'a user agent
> *should* set value'), and this CL tests Accept header values against the
values
> used by Chromium (which are different from the values in the spec).
> 
> Should these tests be placed under chromium/ directory?

I think so because webp is supported only in chromium...

Powered by Google App Engine
This is Rietveld 408576698