Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185333002: DevTools: complete the move of UI builders from timeline presentation record to timeline ui uti… (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: complete the move of UI builders from timeline presentation record to timeline ui utils. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168285

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -363 lines) Patch
M LayoutTests/inspector/timeline/timeline-node-reference.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 1 2 chunks +0 lines, -359 lines 0 comments Download
M Source/devtools/front_end/TimelineUIUtils.js View 1 1 chunk +359 lines, -0 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pfeldman
This is a pure move, no changes to the semantics.
6 years, 9 months ago (2014-03-01 13:51:14 UTC) #1
caseq
https://codereview.chromium.org/185333002/diff/1/Source/devtools/front_end/TimelinePanel.js File Source/devtools/front_end/TimelinePanel.js (right): https://codereview.chromium.org/185333002/diff/1/Source/devtools/front_end/TimelinePanel.js#newcode837 Source/devtools/front_end/TimelinePanel.js:837: WebInspector.TimelineUIUtils.generatePopupContent.generatePopupContent(record, this._detailsLinkifier, showCallback.bind(this)); WebInspector.TimelineUIUtils.generatePopupContent.generatePopupContent()? We need to go deeper! ...
6 years, 9 months ago (2014-03-03 09:15:35 UTC) #2
pfeldman
https://codereview.chromium.org/185333002/diff/1/Source/devtools/front_end/TimelinePanel.js File Source/devtools/front_end/TimelinePanel.js (right): https://codereview.chromium.org/185333002/diff/1/Source/devtools/front_end/TimelinePanel.js#newcode837 Source/devtools/front_end/TimelinePanel.js:837: WebInspector.TimelineUIUtils.generatePopupContent.generatePopupContent(record, this._detailsLinkifier, showCallback.bind(this)); Oops, yes, I had this fixed ...
6 years, 9 months ago (2014-03-03 09:35:32 UTC) #3
caseq
lgtm
6 years, 9 months ago (2014-03-03 09:36:02 UTC) #4
pfeldman
6 years, 9 months ago (2014-03-03 09:38:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r168285 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698