Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: Source/devtools/front_end/TimelineView.js

Issue 185333002: DevTools: complete the move of UI builders from timeline presentation record to timeline ui uti… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comments addressed. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineView.js
diff --git a/Source/devtools/front_end/TimelineView.js b/Source/devtools/front_end/TimelineView.js
index 610826884a6ce47264bf29b5b312153643a6452b..f3483016ceb851aacf37a358187acd8c4944d668 100644
--- a/Source/devtools/front_end/TimelineView.js
+++ b/Source/devtools/front_end/TimelineView.js
@@ -803,7 +803,7 @@ WebInspector.TimelineView.prototype = {
popover.show(WebInspector.TimelineUIUtils.generatePopupContentForFrame(frame), anchor);
} else {
if (anchor.row && anchor.row._record)
- anchor.row._record.generatePopupContent(anchor.row._record, this._linkifier, showCallback);
+ WebInspector.TimelineUIUtils.generatePopupContent(anchor.row._record, this._linkifier, showCallback);
else if (anchor._tasksInfo)
popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent(this._model, anchor._tasksInfo), anchor, null, null, WebInspector.Popover.Orientation.Bottom);
}
@@ -1030,7 +1030,7 @@ WebInspector.TimelineRecordListRow.prototype = {
this._warningElement.enableStyleClass("hidden", !record.hasWarnings() && !record.childHasWarnings());
this._warningElement.enableStyleClass("timeline-tree-item-child-warning", record.childHasWarnings() && !record.hasWarnings());
- var detailsNode = record.buildDetailsNode(record, this._linkifier);
+ var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNode(record, this._linkifier);
if (detailsNode) {
this._dataElement.appendChild(document.createTextNode("("));
this._dataElement.appendChild(detailsNode);
« no previous file with comments | « Source/devtools/front_end/TimelineUIUtils.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698