core/fpdfdoc/cpvt_color.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpvt_color.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix unit tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfdoc/cpvt_color.cpp

diff --git a/core/fpdfdoc/cpvt_color.cpp b/core/fpdfdoc/cpvt_color.cpp

index afeff23e154663840ac4fab2533b31ea73efcc22..7ddb9df0d083ac719a70c123f4836d60a9285237 100644

--- a/core/fpdfdoc/cpvt_color.cpp

+++ b/core/fpdfdoc/cpvt_color.cpp

@@ -10,7 +10,7 @@

// Static.

CPVT_Color CPVT_Color::ParseColor(const CFX_ByteString& str) {

- CPDF_SimpleParser syntax(str);

+ CPDF_SimpleParser syntax(str.AsByteStringC());

if (syntax.FindTagParamFromStart("g", 1))

return CPVT_Color(CPVT_Color::kGray, FX_atof(syntax.GetWord()));

« core/fpdfapi/fpdf_parser/cpdf_string.cpp ('K') | « core/fpdfapi/fpdf_parser/include/cpdf_object.h ('k') | core/fpdfdoc/cpvt_fontmap.cpp » ('j') | no next file with comments »