core/fpdfapi/fpdf_parser/cpdf_string.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_string.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix unit tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/fpdfapi/fpdf_parser/cpdf_string.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_string.cpp b/core/fpdfapi/fpdf_parser/cpdf_string.cpp

index 9a88e937ab64270e49d72f24b6cab2554c5c3452..3f04d125a26b69e86646564cfbfd7bb153f37a59 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_string.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_string.cpp

@@ -32,7 +32,7 @@ CFX_ByteString CPDF_String::GetString() const {

}

CFX_ByteStringC CPDF_String::GetConstString() const {

- return CFX_ByteStringC(m_String);

+ return m_String.AsByteStringC();

Lei Zhang 2016/04/04 22:59:04 Fix CPDF_Name::GetConstString() as well?

Tom Sepez 2016/04/04 23:24:28 Good idea. done.

}

void CPDF_String::SetString(const CFX_ByteString& str) {

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp » ('j') | no next file with comments »