core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1853233002: Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix unit tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index a5db2d6d20d7b59f119c4cc0896c4f0aec0ab2cd..a3c88c00df85805e761d4ddcea0113df8752c12b 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -427,7 +427,7 @@ CPDF_Object* CPDF_StreamParser::ReadNextObject(FX_BOOL bAllowNestedArray,

return nullptr;

}

if (!key.IsEmpty()) {

- pDict->SetAt(key, pObj);

+ pDict->SetAt(key.AsByteStringC(), pObj);

} else {

pObj->Release();

}

« no previous file with comments | « core/fpdfapi/fpdf_page/fpdf_page_parser.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_number.cpp » ('j') | core/fpdfapi/fpdf_parser/cpdf_string.cpp » ('J')