Issue 185323002: DevTools: prepare to move UI builders from timeline presentation record to timeline ui utils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185323002: DevTools: prepare to move UI builders from timeline presentation record to timeline ui utils. (Closed)

Created:
6 years, 9 months ago by pfeldman

Modified:
6 years, 9 months ago

Reviewers:
caseq, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: prepare to move UI builders from timeline presentation record to timeline ui utils. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168284

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+207 lines, -182 lines)			Patch
M	LayoutTests/inspector/timeline/timeline-node-reference.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/TimelinePanel.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/TimelinePresentationModel.js	View	1	12 chunks	+200 lines, -174 lines	1 comment	Download
M	Source/devtools/front_end/TimelineUIUtils.js	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/TimelineView.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

caseq

lgtm https://codereview.chromium.org/185323002/diff/10006/Source/devtools/front_end/TimelinePresentationModel.js File Source/devtools/front_end/TimelinePresentationModel.js (right): https://codereview.chromium.org/185323002/diff/10006/Source/devtools/front_end/TimelinePresentationModel.js#newcode805 Source/devtools/front_end/TimelinePresentationModel.js:805: * @param {?Object|undefined} value ?Object=

6 years, 9 months ago (2014-03-03 08:29:25 UTC) #2

pfeldman

> {?Object|undefined} value > ?Object= I always call it with two parameters, so I think ...

6 years, 9 months ago (2014-03-03 09:29:24 UTC) #3

pfeldman

6 years, 9 months ago (2014-03-03 09:31:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r168284 (presubmit successful).

Expand Messages | Collapse Messages