Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2056)

Unified Diff: Source/devtools/front_end/TimelineView.js

Issue 185323002: DevTools: prepare to move UI builders from timeline presentation record to timeline ui utils. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/TimelineView.js
diff --git a/Source/devtools/front_end/TimelineView.js b/Source/devtools/front_end/TimelineView.js
index 5cbc4b58a29c0cff91ca375d51a963636833e0a6..610826884a6ce47264bf29b5b312153643a6452b 100644
--- a/Source/devtools/front_end/TimelineView.js
+++ b/Source/devtools/front_end/TimelineView.js
@@ -134,7 +134,7 @@ WebInspector.TimelineView.prototype = {
var dividerPosition = Math.round(positions.left);
if (dividerPosition < 0 || dividerPosition >= clientWidth || dividers[dividerPosition])
continue;
- var divider = WebInspector.TimelineUIUtils.createEventDivider(record.type, WebInspector.TimelineUIUtils.recordTitle(this._model, record));
+ var divider = WebInspector.TimelineUIUtils.createEventDivider(record.type, WebInspector.TimelineUIUtils.recordTitle(record));
divider.style.left = dividerPosition + "px";
dividers[dividerPosition] = divider;
}
@@ -803,7 +803,7 @@ WebInspector.TimelineView.prototype = {
popover.show(WebInspector.TimelineUIUtils.generatePopupContentForFrame(frame), anchor);
} else {
if (anchor.row && anchor.row._record)
- anchor.row._record.generatePopupContent(this._linkifier, showCallback);
+ anchor.row._record.generatePopupContent(anchor.row._record, this._linkifier, showCallback);
else if (anchor._tasksInfo)
popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent(this._model, anchor._tasksInfo), anchor, null, null, WebInspector.Popover.Orientation.Bottom);
}
@@ -1030,7 +1030,7 @@ WebInspector.TimelineRecordListRow.prototype = {
this._warningElement.enableStyleClass("hidden", !record.hasWarnings() && !record.childHasWarnings());
this._warningElement.enableStyleClass("timeline-tree-item-child-warning", record.childHasWarnings() && !record.hasWarnings());
- var detailsNode = record.buildDetailsNode(this._linkifier);
+ var detailsNode = record.buildDetailsNode(record, this._linkifier);
if (detailsNode) {
this._dataElement.appendChild(document.createTextNode("("));
this._dataElement.appendChild(detailsNode);

Powered by Google App Engine
This is Rietveld 408576698