Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1853073003: [DevTools] Add "Show all" check box in Service Worker view. (Closed)

Created:
4 years, 8 months ago by horo
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add "Show all" check box in Service Worker view. There are some requests from web developers to provide a way to debug SWs before opening the page. This cl adds "Show all" check box which shows all SWs in DevTools. BUG=597538 Committed: https://crrev.com/1f17e936b00b806271cde194bb570e4b3790846a Cr-Commit-Position: refs/heads/master@{#385372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 6 chunks +30 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/serviceWorkersView.css View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
horo
pfeldman@ Could you please review this CL? I think ServiceWorkersView should have "show all" checkbox ...
4 years, 8 months ago (2016-04-04 07:02:29 UTC) #2
pfeldman
lgtm - lets land it for now.
4 years, 8 months ago (2016-04-06 01:12:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853073003/1
4 years, 8 months ago (2016-04-06 01:38:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 03:07:30 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 03:08:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f17e936b00b806271cde194bb570e4b3790846a
Cr-Commit-Position: refs/heads/master@{#385372}

Powered by Google App Engine
This is Rietveld 408576698