Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 1853073003: [DevTools] Add "Show all" check box in Service Worker view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/resources/serviceWorkersView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
index 133edf29b48794f3739e4c9c247eb2dd4c392c93..1480638e9f2558a77c14e2bb4396f1b3d4d5f4dc 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
@@ -13,6 +13,9 @@ WebInspector.ServiceWorkersView = function()
this.registerRequiredCSS("resources/serviceWorkersView.css");
this.contentElement.classList.add("service-workers-view");
+
+ /** @type {boolean} */
+ this._showAll = false;
/** @type {!Set.<string>} */
this._securityOriginHosts = new Set();
/** @type {!Map.<string, !WebInspector.ServiceWorkerOriginWidget>} */
@@ -43,6 +46,10 @@ WebInspector.ServiceWorkersView.prototype = {
var forceUpdate = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Update on reload"), WebInspector.UIString("Update Service Worker on page reload"), this._manager.forceUpdateOnReloadSetting());
this._toolbar.appendToolbarItem(forceUpdate);
+ this._showAllCheckbox = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Show all"), WebInspector.UIString("Show all Service Workers"));
+ this._showAllCheckbox.inputElement.addEventListener("change", this._onShowAllCheckboxChanged.bind(this), false);
+ this._toolbar.appendToolbarItem(this._showAllCheckbox);
+
for (var registration of this._manager.registrations().values())
this._updateRegistration(registration);
@@ -67,6 +74,25 @@ WebInspector.ServiceWorkersView.prototype = {
},
/**
+ * @param {!Event} event
+ */
+ _onShowAllCheckboxChanged: function(event)
+ {
+ this._showAll = this._showAllCheckbox.checked();
+ if (this._showAll) {
+ for (var originWidget of this._originHostToOriginWidgetMap.values()) {
+ if (!originWidget.parentWidget())
+ originWidget.show(this._root);
+ }
+ } else {
+ for (var originWidget of this._originHostToOriginWidgetMap.values()) {
+ if (originWidget.parentWidget() && !this._securityOriginHosts.has(originWidget._originHost))
+ originWidget.detach();
+ }
+ }
+ },
+
+ /**
* @param {!WebInspector.Event} event
*/
_registrationUpdated: function(event)
@@ -87,7 +113,7 @@ WebInspector.ServiceWorkersView.prototype = {
var originWidget = this._originHostToOriginWidgetMap.get(originHost);
if (!originWidget) {
originWidget = new WebInspector.ServiceWorkerOriginWidget(this._manager, originHost);
- if (this._securityOriginHosts.has(originHost))
+ if (this._securityOriginHosts.has(originHost) || this._showAll)
originWidget.show(this._root);
this._originHostToOriginWidgetMap.set(originHost, originWidget);
}
@@ -109,7 +135,7 @@ WebInspector.ServiceWorkersView.prototype = {
originWidget._deleteRegistration(registrationId);
if (originWidget._hasRegistration())
return;
- if (this._securityOriginHosts.has(originWidget._originHost))
+ if (originWidget.parentWidget())
originWidget.detach();
this._originHostToOriginWidgetMap.delete(originWidget._originHost);
},
@@ -153,6 +179,8 @@ WebInspector.ServiceWorkersView.prototype = {
if (!this._securityOriginHosts.has(originHost))
return;
this._securityOriginHosts.delete(originHost);
+ if (this._showAll)
+ return;
var originWidget = this._originHostToOriginWidgetMap.get(originHost);
if (!originWidget)
return;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/resources/serviceWorkersView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698