Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 185303013: Remove Perl cruft from IDL compiler front end (mostly JSON export) (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Remove Perl cruft from IDL compiler front end (mostly JSON export) Mostly just remove code: net -190 lines (also group type classes together, and replace some None with False) Further simplification is possible, as we no longer need classes for enums and unions; will do in followup, b/c more involved. BUG=345137 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -270 lines) Patch
M Source/bindings/scripts/idl_definitions.py View 8 chunks +78 lines, -263 lines 0 comments Download
M Source/bindings/scripts/idl_definitions_builder.py View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nils Barth (inactive)
6 years, 9 months ago (2014-03-04 00:35:10 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-04 00:35:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/185303013/1
6 years, 9 months ago (2014-03-04 00:35:58 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-04 00:38:15 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 9 months ago (2014-03-04 08:51:29 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-04 08:51:36 UTC) #6
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 01:44:44 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 01:44:45 UTC) #8
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 11:58:31 UTC) #9
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-05 11:58:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/185303013/1
6 years, 9 months ago (2014-03-05 11:59:21 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 11:59:50 UTC) #12
Message was sent while issue was closed.
Change committed as 168470

Powered by Google App Engine
This is Rietveld 408576698