Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: Source/bindings/scripts/idl_definitions_builder.py

Issue 185303013: Remove Perl cruft from IDL compiler front end (mostly JSON export) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/idl_definitions.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/idl_definitions_builder.py
diff --git a/Source/bindings/scripts/idl_definitions_builder.py b/Source/bindings/scripts/idl_definitions_builder.py
index 6e7f9f46161bef55ec4fe87311e29bd617e7a814..49153a880e39331109918b3231e565315e5ef200 100644
--- a/Source/bindings/scripts/idl_definitions_builder.py
+++ b/Source/bindings/scripts/idl_definitions_builder.py
@@ -54,9 +54,6 @@ def file_node_to_idl_definitions(node):
interfaces = {}
typedefs = STANDARD_TYPEDEFS
- # FIXME: only needed for Perl, remove later
- file_name = os.path.abspath(node.GetName())
-
children = node.GetChildren()
for child in children:
child_class = child.GetClass()
@@ -82,7 +79,7 @@ def file_node_to_idl_definitions(node):
else:
raise ValueError('Unrecognized node class: %s' % child_class)
- return IdlDefinitions(callback_functions=callback_functions, enumerations=enumerations, file_name=file_name, interfaces=interfaces, typedefs=typedefs)
+ return IdlDefinitions(callback_functions=callback_functions, enumerations=enumerations, interfaces=interfaces, typedefs=typedefs)
# Constructors for Interface definitions and interface members
@@ -220,11 +217,9 @@ def argument_node_to_idl_argument(node):
idl_type = None
extended_attributes = {}
- # FIXME: Boolean values are inconsistent due to Perl compatibility.
- # Make all default to False once Perl removed.
is_nullable = False
is_optional = node.GetProperty('OPTIONAL')
- is_variadic = None
+ is_variadic = False
children = node.GetChildren()
for child in children:
child_class = child.GetClass()
« no previous file with comments | « Source/bindings/scripts/idl_definitions.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698