Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by Nico Modified:
4 years, 8 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionLet v8's configs have an effect in 64-bit Windows Chromium builds.
The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64"
as configs for some reason, so put v8's build config settings there
too.
Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from
25s to 12s on my z840 in a 64-bit Chromium debug build
(while also turning on handle zapping).
BUG=chromium:586511
LOG=n
Committed: https://crrev.com/42f2261cfe6e24948ee43f7ea0e15d4563899617
Cr-Commit-Position: refs/heads/master@{#35224}
Patch Set 1 #
Created: 4 years, 8 months ago
Messages
Total messages: 15 (8 generated)
thakis@chromium.org changed reviewers: + jochen@chromium.org
Description was changed from ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 (while also turning on handle zapping). BUG=chromium:586511 ========== to ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 (while also turning on handle zapping). BUG=chromium:586511 LOG=n ==========
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852913002/1
Description was changed from ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 (while also turning on handle zapping). BUG=chromium:586511 LOG=n ========== to ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 in a 64-bit Chromium debug build (while also turning on handle zapping). BUG=chromium:586511 LOG=n ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852913002/1
Message was sent while issue was closed.
Description was changed from ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 in a 64-bit Chromium debug build (while also turning on handle zapping). BUG=chromium:586511 LOG=n ========== to ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 in a 64-bit Chromium debug build (while also turning on handle zapping). BUG=chromium:586511 LOG=n ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 in a 64-bit Chromium debug build (while also turning on handle zapping). BUG=chromium:586511 LOG=n ========== to ========== Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 in a 64-bit Chromium debug build (while also turning on handle zapping). BUG=chromium:586511 LOG=n Committed: https://crrev.com/42f2261cfe6e24948ee43f7ea0e15d4563899617 Cr-Commit-Position: refs/heads/master@{#35224} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/42f2261cfe6e24948ee43f7ea0e15d4563899617 Cr-Commit-Position: refs/heads/master@{#35224} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
