Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1852913002: Let v8's configs have an effect in 64-bit Windows Chromium builds. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let v8's configs have an effect in 64-bit Windows Chromium builds. The Chromium 64-bit Windows build uses "Debug_x64" and "Release_x64" as configs for some reason, so put v8's build config settings there too. Reduces e.g. the runtime of CrSettingsBrowserTest.CrSettingsTest from 25s to 12s on my z840 in a 64-bit Chromium debug build (while also turning on handle zapping). BUG=chromium:586511 LOG=n Committed: https://crrev.com/42f2261cfe6e24948ee43f7ea0e15d4563899617 Cr-Commit-Position: refs/heads/master@{#35224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M build/toolchain.gypi View 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
4 years, 8 months ago (2016-04-01 23:21:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852913002/1
4 years, 8 months ago (2016-04-02 17:19:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-02 17:43:31 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-03 11:12:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852913002/1
4 years, 8 months ago (2016-04-03 13:06:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-03 13:08:43 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 13:09:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42f2261cfe6e24948ee43f7ea0e15d4563899617
Cr-Commit-Position: refs/heads/master@{#35224}

Powered by Google App Engine
This is Rietveld 408576698