Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2914)

Unified Diff: build/toolchain.gypi

Issue 1852913002: Let v8's configs have an effect in 64-bit Windows Chromium builds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index c2974c52bfc53f42e9bb21895e4c2c8204dc6875..6090898073082da9aeac439f432704515023f3db 100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -1287,7 +1287,8 @@
}],
],
}, # Debug
- 'Release': {
+ 'ReleaseBase': {
+ 'abstract': 1,
'variables': {
'v8_enable_slow_dchecks%': 0,
},
@@ -1367,6 +1368,27 @@
}],
], # conditions
}, # Release
+ 'Release': {
+ 'inherit_from': ['ReleaseBase'],
+ }, # Debug
+ 'conditions': [
+ [ 'OS=="win"', {
+ # TODO(bradnelson): add a gyp mechanism to make this more graceful.
+ 'Debug_x64': {
+ 'inherit_from': ['DebugBaseCommon'],
+ 'conditions': [
+ ['v8_optimized_debug==0', {
+ 'inherit_from': ['DebugBase0'],
+ }, {
+ 'inherit_from': ['DebugBase1'],
+ }],
+ ],
+ },
+ 'Release_x64': {
+ 'inherit_from': ['ReleaseBase'],
+ },
+ }],
+ ],
}, # configurations
}, # target_defaults
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698