Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1852883003: Fix summarizing of types with unused type parameters. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix summarizing of types with unused type parameters. Fixes #26173. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dfa1bb7d4b6605dd5615335da9c7ef38c895f050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -6 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 3 chunks +11 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +43 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-01 23:23:43 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-01 23:26:52 UTC) #3
Paul Berry
4 years, 8 months ago (2016-04-04 16:07:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfa1bb7d4b6605dd5615335da9c7ef38c895f050 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698