Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3865)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_test.dart

Issue 1852883003: Fix summarizing of types with unused type parameters. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart
index dc8fd6d7f06efddcb450402dcba5449da3e48734..faa36ed449404ec1228f8aee01fb444ea508c6f7 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart
@@ -1076,8 +1076,20 @@ abstract class ResynthesizeTest extends AbstractSingleUnitTest {
expect(resynthesized.typeArguments.length, original.typeArguments.length,
reason: desc);
for (int i = 0; i < resynthesized.typeArguments.length; i++) {
- compareTypes(resynthesized.typeArguments[i], original.typeArguments[i],
- '$desc type argument ${original.typeArguments[i].name}');
+ if (resynthesized.typeArguments[i].isDynamic &&
+ original.typeArguments[i] is TypeParameterType) {
+ // It's ok for type arguments to get converted to `dynamic` if they
+ // are not used.
+ expect(
+ isTypeParameterUsed(
+ original.typeArguments[i], original.element.type),
+ isFalse);
+ } else {
+ compareTypes(
+ resynthesized.typeArguments[i],
+ original.typeArguments[i],
+ '$desc type argument ${original.typeArguments[i].name}');
+ }
}
if (original.typeParameters == null) {
expect(resynthesized.typeParameters, isNull, reason: desc);
@@ -1245,6 +1257,25 @@ abstract class ResynthesizeTest extends AbstractSingleUnitTest {
}
}
+ /**
+ * Determine if [type] makes use of the given [typeParameter].
+ */
+ bool isTypeParameterUsed(TypeParameterType typeParameter, DartType type) {
+ if (type is FunctionType) {
+ return isTypeParameterUsed(typeParameter, type.returnType) ||
+ type.parameters.any((ParameterElement e) =>
+ isTypeParameterUsed(typeParameter, e.type));
+ } else if (type is InterfaceType) {
+ return type.typeArguments
+ .any((DartType t) => isTypeParameterUsed(typeParameter, t));
+ } else if (type is TypeParameterType) {
+ return type == typeParameter;
+ } else {
+ expect(type.isDynamic || type.isVoid, isTrue);
+ return false;
+ }
+ }
+
@override
void setUp() {
super.setUp();
@@ -4088,6 +4119,16 @@ typedef F();''');
checkLibrary('f() {} g() {}');
}
+ test_unused_type_parameter() {
+ checkLibrary('''
+class C<T> {
+ void f() {}
+}
+C<int> c;
+var v = c.f;
+''');
+ }
+
test_variable_const() {
checkLibrary('const int i = 0;');
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698