Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1852823003: Disable testIsTracingRunning for guest login. (Closed)

Created:
4 years, 8 months ago by achuithb
Modified:
4 years, 8 months ago
Reviewers:
khmel
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M telemetry/telemetry/internal/browser/browser_unittest.py View 1 chunk +1 line, -0 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852823003/1
4 years, 8 months ago (2016-04-01 23:38:43 UTC) #2
achuithb
Yury, this should fix the bot failures.
4 years, 8 months ago (2016-04-01 23:43:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 23:51:53 UTC) #6
khmel
https://codereview.chromium.org/1852823003/diff/1/telemetry/telemetry/internal/browser/browser_unittest.py File telemetry/telemetry/internal/browser/browser_unittest.py (right): https://codereview.chromium.org/1852823003/diff/1/telemetry/telemetry/internal/browser/browser_unittest.py#newcode116 telemetry/telemetry/internal/browser/browser_unittest.py:116: @decorators.Disabled('cros-chrome-guest', 'system-guest') # chromeos guest As I understand, this ...
4 years, 8 months ago (2016-04-02 00:46:14 UTC) #7
khmel
4 years, 8 months ago (2016-04-02 00:46:15 UTC) #8
achuithb
On 2016/04/02 00:46:14, khmel wrote: > https://codereview.chromium.org/1852823003/diff/1/telemetry/telemetry/internal/browser/browser_unittest.py > File telemetry/telemetry/internal/browser/browser_unittest.py (right): > > https://codereview.chromium.org/1852823003/diff/1/telemetry/telemetry/internal/browser/browser_unittest.py#newcode116 > ...
4 years, 8 months ago (2016-04-02 00:48:04 UTC) #9
khmel
lgtm
4 years, 8 months ago (2016-04-02 00:48:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852823003/1
4 years, 8 months ago (2016-04-02 00:49:54 UTC) #12
achuithb
On 2016/04/02 00:48:53, khmel wrote: > lgtm ty
4 years, 8 months ago (2016-04-02 00:49:55 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:51:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698