Speculative fix for a possible race.

Speculative fix for a possible race in browser restart.

It's possible that the dbus-send takes an arbitrary long time to restart chrome, and we may "wait" for old chrome to come up rather than the new one.

Check that the chrome pid has changed to ensure chrome has restarted before proceeding.

Also additional logging on chromeos.

BUG=chromium:631640
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d7888dd23836c24b2fb8ffa3f43d19256843bddd

[achuithb, 2016-08-19 00:18:33]

achuith@chromium.org changed reviewers:
+ jamescook@chromium.org

[achuithb, 2016-08-19 00:18:34]

James, PTAL

[James Cook, 2016-08-19 00:23:59]

LGTM with nit

Also, can you update the CL title with something like "a race in browser
startup" or some such?

https://codereview.chromium.org/2260063002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/2260063002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:57:
logging_patterns = ['chromeos/net/*',
nit: I think this would be easier to read if you did either:

'*/foo/bar/*',

or

'*/foo/bar/*=2',

on each line. I don't think the repetition is a problem.

[achuithb, 2016-08-19 00:45:15]

Patchset #2 (id:20001) has been deleted

[achuithb, 2016-08-19 00:46:27]

Description was changed from

==========
Speculative fix for a possible race.

It's possible that the dbus-send takes an arbitrary long time to restart chrome.
Check that the chrome pid has changed to ensure chrome has restarted before
proceeding.

Also additional logging on chromeos.

BUG=chromium:631640
==========

to

==========
Speculative fix for a possible race in browser restart.

It's possible that the dbus-send takes an arbitrary long time to restart chrome,
and we may "wait" for old chrome to come up rather than the new one.

Check that the chrome pid has changed to ensure chrome has restarted before
proceeding.

Also additional logging on chromeos.

BUG=chromium:631640
==========

[achuithb, 2016-08-19 00:46:35]

https://codereview.chromium.org/2260063002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
(right):

https://codereview.chromium.org/2260063002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:57:
logging_patterns = ['chromeos/net/*',
On 2016/08/19 00:23:59, James Cook (slow reviews) wrote:
> nit: I think this would be easier to read if you did either:
> 
> '*/foo/bar/*',
> 
> or
> 
> '*/foo/bar/*=2',
> 
> on each line. I don't think the repetition is a problem.

Done.

[achuithb, 2016-08-19 00:46:47]

On 2016/08/19 00:23:59, James Cook (slow reviews) wrote:
> LGTM with nit
> 
> Also, can you update the CL title with something like "a race in browser
> startup" or some such?
> 
Done

[achuithb, 2016-08-19 00:46:54]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2016-08-19 00:46:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2260063002/#ps40001
(title: "jamescook feedback")

[commit-bot: I haz the power, 2016-08-19 00:47:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2016-08-19 00:49:03]

achuith@chromium.org changed reviewers:
+ nednguyen@google.com

[achuithb, 2016-08-19 00:49:04]

Ned, another rubberstamp please

[nednguyen, 2016-08-19 00:52:55]

lgtm

[commit-bot: I haz the power, 2016-08-19 01:09:39]

Description was changed from

==========
Speculative fix for a possible race in browser restart.

It's possible that the dbus-send takes an arbitrary long time to restart chrome,
and we may "wait" for old chrome to come up rather than the new one.

Check that the chrome pid has changed to ensure chrome has restarted before
proceeding.

Also additional logging on chromeos.

BUG=chromium:631640
==========

to

==========
Speculative fix for a possible race in browser restart.

It's possible that the dbus-send takes an arbitrary long time to restart chrome,
and we may "wait" for old chrome to come up rather than the new one.

Check that the chrome pid has changed to ensure chrome has restarted before
proceeding.

Also additional logging on chromeos.

BUG=chromium:631640

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-08-19 01:09:40]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...