Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1852743002: Update SkBlurImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : update to ToT #

Total comments: 2

Patch Set 4 : Update to ToT & address code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -297 lines) Patch
M bench/BlurImageFilterBench.cpp View 4 chunks +31 lines, -28 lines 0 comments Download
M bench/ImageFilterDAGBench.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M gm/coloremoji.cpp View 3 chunks +11 lines, -14 lines 0 comments Download
M gm/colorfilterimagefilter.cpp View 3 chunks +44 lines, -41 lines 0 comments Download
M gm/complexclip_blur_tiled.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 4 chunks +22 lines, -36 lines 0 comments Download
M gm/imageblur.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imageblur2.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M gm/imageblurtiled.cpp View 2 chunks +9 lines, -11 lines 0 comments Download
M gm/imagefilters.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M gm/imagefiltersbase.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 1 chunk +6 lines, -8 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersstroked.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefilterstransformed.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/localmatriximagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/spritebitmap.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M gm/testimagefilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurImageFilter.h View 3 chunks +12 lines, -5 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/utils/SkLua.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 15 chunks +119 lines, -88 lines 0 comments Download
M tests/RecordOptsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852743002/20001
4 years, 8 months ago (2016-04-01 17:32:18 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852743002/40001
4 years, 8 months ago (2016-04-01 18:04:37 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 18:21:28 UTC) #9
robertphillips
ping
4 years, 8 months ago (2016-04-03 16:05:48 UTC) #10
reed1
api lgtm you'll likely need to manually rebase, as I just changed CreateProc to return ...
4 years, 8 months ago (2016-04-03 16:33:29 UTC) #11
f(malita)
lgtm https://codereview.chromium.org/1852743002/diff/40001/tests/ImageFilterTest.cpp File tests/ImageFilterTest.cpp (right): https://codereview.chromium.org/1852743002/diff/40001/tests/ImageFilterTest.cpp#newcode211 tests/ImageFilterTest.cpp:211: sk_sp<SkImageFilter> pictureFilter(SkPictureImageFilter::Make(picture)); nit: std::move(picture)
4 years, 8 months ago (2016-04-03 16:47:51 UTC) #12
robertphillips
https://codereview.chromium.org/1852743002/diff/40001/tests/ImageFilterTest.cpp File tests/ImageFilterTest.cpp (right): https://codereview.chromium.org/1852743002/diff/40001/tests/ImageFilterTest.cpp#newcode211 tests/ImageFilterTest.cpp:211: sk_sp<SkImageFilter> pictureFilter(SkPictureImageFilter::Make(picture)); On 2016/04/03 16:47:50, f(malita) wrote: > nit: ...
4 years, 8 months ago (2016-04-03 20:18:01 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852743002/60001
4 years, 8 months ago (2016-04-03 20:18:12 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 20:29:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852743002/60001
4 years, 8 months ago (2016-04-04 11:29:41 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 11:31:29 UTC) #22
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6e7025ab13dfc4f0037233e67b4b8e18d6dfd1e1

Powered by Google App Engine
This is Rietveld 408576698