Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1852733002: Add GrContext::releaseAndAbandonContext() (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GrContext::releaseAndAbandonContext() Like abandonContext() this disconnects the GrContext from the underlying 3D API. However, unlike abandonContext it first frees all allocated GPU resources. BUG=skia:5142 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852733002 Committed: https://skia.googlesource.com/skia/+/6e2aad4e9f6280aa2b710e7324458fdc6d699ec5

Patch Set 1 #

Patch Set 2 : add comments #

Patch Set 3 : Fix no-gpu build, add null check, add unit test" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -30 lines) Patch
M dm/DMGpuSupport.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +20 lines, -12 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +20 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +11 lines, -5 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 2 chunks +48 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +4 lines, -1 line 0 comments Download
A tests/GrContextAbandonTest.cpp View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bsalomon
This allows some untangling of GL Context related classes in Chromium. I'll request that we ...
4 years, 8 months ago (2016-04-01 15:09:19 UTC) #3
robertphillips
lgtm - testing is going to be key!
4 years, 8 months ago (2016-04-01 16:41:14 UTC) #4
bsalomon
On 2016/04/01 16:41:14, robertphillips wrote: > lgtm - testing is going to be key! agreed!
4 years, 8 months ago (2016-04-01 17:20:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852733002/20001
4 years, 8 months ago (2016-04-01 17:21:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/7533)
4 years, 8 months ago (2016-04-01 17:30:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852733002/40001
4 years, 8 months ago (2016-04-01 18:40:14 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:54:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6e2aad4e9f6280aa2b710e7324458fdc6d699ec5

Powered by Google App Engine
This is Rietveld 408576698