Issue 1852463002: Don't fall back to default incognito colors and tints when using a custom theme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1852463002: Don't fall back to default incognito colors and tints when using a custom theme. (Closed)

Created:
4 years, 8 months ago by Evan Stade

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Don't fall back to default incognito colors and tints when using a custom theme. BUG=596136 Review URL: https://codereview.chromium.org/1813393002 Cr-Commit-Position: refs/heads/master@{#383895} (cherry picked from commit 66736a7734ef10200f9a653502464260877fd397) Committed: https://chromium.googlesource.com/chromium/src/+/3e74fd51a4eb0b3f7571b3dc39e5ec09dcf972a8

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/themes/theme_service.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Evan Stade

4 years, 8 months ago (2016-03-31 16:42:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3e74fd51a4eb0b3f7571b3dc39e5ec09dcf972a8.