Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 1852463002: Don't fall back to default incognito colors and tints when using a custom theme. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_service.cc
diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc
index be26a3022714599167053cffd81c756114735bb1..659d013623b37418e1ffeeab0abecd3ef4fc1a2d 100644
--- a/chrome/browser/themes/theme_service.cc
+++ b/chrome/browser/themes/theme_service.cc
@@ -346,7 +346,9 @@ color_utils::HSL ThemeService::GetTint(int id, bool incognito) const {
if (theme_supplier_ && theme_supplier_->GetTint(id, &hsl))
return hsl;
- return ThemeProperties::GetDefaultTint(id, incognito);
+ // Always fall back to the non-incognito tint when there's a custom theme.
+ // See comment in GetDefaultColor().
+ return ThemeProperties::GetDefaultTint(id, incognito && !theme_supplier_);
}
void ThemeService::ClearAllThemeData() {
@@ -622,7 +624,10 @@ SkColor ThemeService::GetColor(int id, bool incognito) const {
}
}
- return ThemeProperties::GetDefaultColor(id, incognito);
+ // Always fall back to the non-incognito color when there's a custom theme
+ // because the default (classic) incognito color may be dramatically different
+ // (optimized for a light-on-dark color).
+ return ThemeProperties::GetDefaultColor(id, incognito && !theme_supplier_);
}
int ThemeService::GetDisplayProperty(int id) const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698