Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1852453004: Revert "Use CFX_RetainPtr to ref count CFX_ByteString" (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Use CFX_RetainPtr to ref count CFX_ByteString" This reverts commit ac88953dfa7c1a68c69989d61d7bc03c0595064b. Reason for revert: Strings borked. TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b33dfdf68bafa30e90a65fb71ff6b343202e0561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -391 lines) Patch
M core/fxcrt/fx_basic_bstring.cpp View 13 chunks +372 lines, -340 lines 0 comments Download
M core/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 16 chunks +92 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852453004/1
4 years, 8 months ago (2016-03-31 19:42:31 UTC) #5
dsinclair
lgtm
4 years, 8 months ago (2016-03-31 19:53:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 19:54:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/b33dfdf68bafa30e90a65fb71ff6b343202e...

Powered by Google App Engine
This is Rietveld 408576698