Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6443)

Unified Diff: core/fxcrt/fx_basic_bstring_unittest.cpp

Issue 1852453004: Revert "Use CFX_RetainPtr to ref count CFX_ByteString" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/fx_basic_bstring.cpp ('k') | core/fxcrt/include/fx_string.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/fx_basic_bstring_unittest.cpp
diff --git a/core/fxcrt/fx_basic_bstring_unittest.cpp b/core/fxcrt/fx_basic_bstring_unittest.cpp
index 6e360448c7c9d8fa02c7b8892ab549241bb9b0ec..834a6e444db8fcbf3881838cf230833920f8dbfe 100644
--- a/core/fxcrt/fx_basic_bstring_unittest.cpp
+++ b/core/fxcrt/fx_basic_bstring_unittest.cpp
@@ -288,28 +288,28 @@ TEST(fxcrt, ByteStringCNull) {
EXPECT_NE(null_string, non_null_string);
}
-TEST(fxcrt, ByteStringConcat) {
+TEST(fxcrt, ByteStringConcatInPlace) {
CFX_ByteString fred;
- fred.Concat("FRED", 4);
+ fred.ConcatInPlace(4, "FRED");
EXPECT_EQ("FRED", fred);
- fred.Concat("DY", 2);
+ fred.ConcatInPlace(2, "DY");
EXPECT_EQ("FREDDY", fred);
fred.Delete(3, 3);
EXPECT_EQ("FRE", fred);
- fred.Concat("D", 1);
+ fred.ConcatInPlace(1, "D");
EXPECT_EQ("FRED", fred);
CFX_ByteString copy = fred;
- fred.Concat("DY", 2);
+ fred.ConcatInPlace(2, "DY");
EXPECT_EQ("FREDDY", fred);
EXPECT_EQ("FRED", copy);
// Test invalid arguments.
copy = fred;
- fred.Concat("freddy", -6);
+ fred.ConcatInPlace(-6, "freddy");
CFX_ByteString not_aliased("xxxxxx");
EXPECT_EQ("FREDDY", fred);
EXPECT_EQ("xxxxxx", not_aliased);
« no previous file with comments | « core/fxcrt/fx_basic_bstring.cpp ('k') | core/fxcrt/include/fx_string.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698