base/metrics/histogram_samples.cc - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_samples.cc

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase after r384946 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_samples.cc

diff --git a/base/metrics/histogram_samples.cc b/base/metrics/histogram_samples.cc

index 246a020495222be9806c90e36c153d378fe8d854..d42bd00fce7d932c690bca6692db13a6c2ba4144 100644

--- a/base/metrics/histogram_samples.cc

+++ b/base/metrics/histogram_samples.cc

@@ -141,8 +141,7 @@ bool HistogramSamples::Serialize(Pickle* pickle) const {

HistogramBase::Sample min;

HistogramBase::Sample max;

HistogramBase::Count count;

- for (scoped_ptr<SampleCountIterator> it = Iterator();

- !it->Done();

+ for (std::unique_ptr<SampleCountIterator> it = Iterator(); !it->Done();

it->Next()) {

it->Get(&min, &max, &count);

if (!pickle->WriteInt(min) ||

« no previous file with comments | « base/metrics/histogram_samples.h ('k') | base/metrics/histogram_snapshot_manager.h » ('j') | no next file with comments »