base/metrics/histogram_delta_serialization_unittest.cc - Issue 1852433005: Convert //base to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_delta_serialization_unittest.cc

Issue 1852433005: Convert //base to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove redundant base:: prefix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_delta_serialization_unittest.cc

diff --git a/base/metrics/histogram_delta_serialization_unittest.cc b/base/metrics/histogram_delta_serialization_unittest.cc

index 93f719826f3e7f207077ef65d1fbc7e84476aae5..80a70096716908312467e4fbcc94dacf859add23 100644

--- a/base/metrics/histogram_delta_serialization_unittest.cc

+++ b/base/metrics/histogram_delta_serialization_unittest.cc

@@ -34,7 +34,7 @@ TEST(HistogramDeltaSerializationTest, DeserializeHistogramAndAddSamples) {

HistogramDeltaSerialization::DeserializeAndAddSamples(deltas);

// The histogram has kIPCSerializationSourceFlag. So samples will be ignored.

- scoped_ptr<HistogramSamples> snapshot(histogram->SnapshotSamples());

+ std::unique_ptr<HistogramSamples> snapshot(histogram->SnapshotSamples());

EXPECT_EQ(1, snapshot->GetCount(1));

EXPECT_EQ(1, snapshot->GetCount(10));

EXPECT_EQ(1, snapshot->GetCount(100));

@@ -44,7 +44,7 @@ TEST(HistogramDeltaSerializationTest, DeserializeHistogramAndAddSamples) {

histogram->ClearFlags(HistogramBase::kIPCSerializationSourceFlag);

HistogramDeltaSerialization::DeserializeAndAddSamples(deltas);

- scoped_ptr<HistogramSamples> snapshot2(histogram->SnapshotSamples());

+ std::unique_ptr<HistogramSamples> snapshot2(histogram->SnapshotSamples());

EXPECT_EQ(2, snapshot2->GetCount(1));

EXPECT_EQ(2, snapshot2->GetCount(10));

EXPECT_EQ(2, snapshot2->GetCount(100));